Major rework to header files | clang-tidy integration

.github/workflows/cmake-single-platform.yml

@@ -32,12 +32,13 @@ jobs:
     - name: Build
       # Build your program with the given configuration
       run: cmake --build ${{github.workspace}}/build --config ${{env.BUILD_TYPE}}
-
     - name: Test
       working-directory: ${{github.workspace}}/build
       # Execute tests defined by the CMake configuration.
       # See https://cmake.org/cmake/help/latest/manual/ctest.1.html for more detail
       run: ctest --output-on-failure
+    - name: clang-tidy
+      run: bash ../clang_tidy.sh
     #- name: get coverage
     #  run: make coverage
     #- name: Run tests and collect coverage

clang_tidy.sh

@@ -0,0 +1 @@
+find src/ -name '*.h' -exec clang-tidy {} -- -x c++ -std=c++17 \;

src/algorithms/dynamic_programming/coin_change.h

@@ -1,4 +1,3 @@
-#pragma once
 #ifndef COIN_CHANGE_H
 #define COIN_CHANGE_H
 

src/algorithms/dynamic_programming/fib.h

@@ -1,4 +1,3 @@
-#pragma once
 #ifndef FIB_H
 #define FIB_H
 
@@ -67,4 +66,4 @@ int64_t fibonacci_binet(int64_t n) {
   double phi = (std::sqrt(5) + 1) / 2;
   return (int64_t)std::round(std::pow(phi, n) / sqrt(5));
 }
-#endif
+#endif

src/algorithms/dynamic_programming/kadane.h

@@ -1,4 +1,3 @@
-#pragma once
 #ifndef KADANE_H
 #define KADANE_H
 

src/algorithms/dynamic_programming/lcs.h

@@ -1,11 +1,11 @@
-#pragma once
 #ifndef LCS_H
 #define LCS_H
 
 #ifdef __cplusplus
 #include <cstdint>
 #include <iostream>
 #include <string>
+#include <vector>
 #endif
 
 /**
@@ -15,10 +15,10 @@
  * @param b second input string
  * @return int64_t the longest common subsequence of a to b
  */
-int64_t lcs(std::string a, std::string b) {
+int64_t lcs(const std::string a, const std::string b) {
   int64_t m = a.length(), n = b.length();
-  int64_t res[m + 1][n + 1];
-  int64_t trace[20][20];
+  std::vector<std::vector<int64_t> > res(m + 1, std::vector<int64_t>(n + 1));
+  std::vector<std::vector<int64_t> > trace(20, std::vector<int64_t>(20));
 
   for (int64_t i = 0; i < m + 1; i++) {
     for (int64_t j = 0; j < n + 1; j++) {
@@ -52,4 +52,4 @@ int64_t lcs(std::string a, std::string b) {
   return res[m][n];
 }
 
-#endif
+#endif

src/algorithms/dynamic_programming/lis.h

@@ -1,4 +1,3 @@
-#pragma once
 #ifndef LIS_H
 #define LIS_H
 
@@ -27,4 +26,4 @@ template <typename T> int64_t lis(std::vector<T> arr) {
   return ans.size();
 }
 
-#endif
+#endif

src/algorithms/number_theory/eratosthenes_sieve.h

@@ -1,4 +1,3 @@
-#pragma once
 #ifndef ERATOSTHENES_SIEVE_H
 #define ERATOSTHENES_SIEVE_H
 
@@ -27,4 +26,4 @@ std::vector<bool> soe(int64_t n) {
   return prime;
 }
 
-#endif
+#endif

src/algorithms/number_theory/gcd.h

@@ -1,4 +1,3 @@
-#pragma once
 #ifndef GCD_H
 #define GCD_H
 
@@ -60,4 +59,4 @@ int64_t euclidean_gcd(int64_t a, int64_t b) {
   return (a + b);
 }
 
-#endif
+#endif

src/algorithms/number_theory/mersenne_primes.h

@@ -1,4 +1,3 @@
-#pragma once
 #ifndef MERSENNE_PRIMES_H
 #define MERSENNE_PRIMES_H
 
@@ -25,4 +24,4 @@ std::vector<int> mersenne(int64_t n) {
   }
   return elements;
 }
-#endif
+#endif

src/algorithms/searching/bfs.h

@@ -1,4 +1,3 @@
-#pragma once
 #ifndef BFS_H
 #define BFS_H
 

src/algorithms/searching/binary_search.h

@@ -1,4 +1,3 @@
-#pragma once
 #ifndef BINARY_SEARCH_H
 #define BINARY_SEARCH_H
 

src/algorithms/searching/dfs.h

@@ -1,4 +1,3 @@
-#pragma once
 #ifndef DFS_H
 #define DFS_H
 

src/algorithms/searching/exponential_search.h

@@ -1,4 +1,3 @@
-#pragma once
 #ifndef EXPONENTIAL_SEARCH_H
 #define EXPONENTIAL_SEARCH_H
 
@@ -36,4 +35,4 @@ template <typename T> int64_t exponential_search(std::vector<T> arr, T key) {
   return -1;
 }
 
-#endif
+#endif

src/algorithms/searching/interpolation_search.h

@@ -1,4 +1,3 @@
-#pragma once
 #ifndef INTERPOLATION_SEARCH_H
 #define INTERPOLATION_SEARCH_H
 

src/algorithms/searching/jump_search.h

@@ -1,4 +1,3 @@
-#pragma once
 #ifndef JUMP_SEARCH_H
 #define JUMP_SEARCH_H
 
@@ -33,4 +32,4 @@ template <typename T> int64_t jump_search(std::vector<T> arr, T key) {
   return (arr[prev] == key) ? prev : -1;
 }
 
-#endif
+#endif

src/algorithms/searching/linear_search.h

@@ -1,4 +1,3 @@
-#pragma once
 #ifndef LINEAR_SEARCH_H
 #define LINEAR_SEARCH_H
 
@@ -23,4 +22,4 @@ template <typename T> bool linear_search(std::vector<T> arr, T key) {
   return false;
 }
 
-#endif
+#endif

src/algorithms/searching/ternary_search.h

@@ -1,4 +1,3 @@
-#pragma once
 #ifndef TERNARY_SEARCH_H
 #define TERNARY_SEARCH_H
 

src/algorithms/sorting/bubble_sort.h

@@ -1,4 +1,3 @@
-#pragma once
 #ifndef BUBBLE_SORT_H
 #define BUBBLE_SORT_H
 
@@ -27,4 +26,4 @@ template <typename T> void bubble_sort(std::vector<T> &arr) {
   }
 }
 
-#endif
+#endif

src/algorithms/sorting/bucket_sort.h

@@ -1,4 +1,3 @@
-#pragma once
 #ifndef BUCKET_SORT_H
 #define BUCKET_SORT_H
 

src/algorithms/sorting/counting_sort.h

@@ -1,4 +1,3 @@
-#pragma once
 #ifndef ALGOPLUS_COUNTING_SORT_H
 #define ALGOPLUS_COUNTING_SORT_H
 

src/algorithms/sorting/heap_sort.h

@@ -55,4 +55,4 @@ template <typename T> void heap_sort(std::vector<T> &arr) {
   }
 }
 
-#endif
+#endif

src/algorithms/sorting/insertion_sort.h

@@ -1,4 +1,3 @@
-#pragma once
 #ifndef INSERTION_SORT_H
 #define INSERTION_SORT_H
 
@@ -22,4 +21,4 @@ template <typename T> void insertion_sort(std::vector<T> &arr) {
   }
 }
 
-#endif
+#endif

src/algorithms/sorting/merge_sort.h

@@ -1,4 +1,3 @@
-#pragma once
 #ifndef MERGE_SORT_H
 #define MERGE_SORT_H
 

src/algorithms/sorting/quick_sort.h

@@ -1,4 +1,3 @@
-#pragma once
 #ifndef ALGOPLUS_QUICK_SORT_H
 #define ALGOPLUS_QUICK_SORT_H
 

src/algorithms/sorting/radix_sort.h

@@ -1,4 +1,3 @@
-#pragma once
 #ifndef RADIX_SORT_H
 #define RADIX_SORT_H
 

src/algorithms/sorting/selection_sort.h

@@ -1,4 +1,3 @@
-#pragma once
 #ifndef SELECTION_SORT_H
 #define SELECTION_SORT_H
 
@@ -27,4 +26,4 @@ template <typename T> void selection_sort(std::vector<T> &arr) {
   }
 }
 
-#endif
+#endif

src/algorithms/string/edit_distance.h

@@ -1,11 +1,11 @@
-#pragma once
 #ifndef MIN_DISTANCE_H
 #define MIN_DISTANCE_H
 
 #ifdef __cplusplus
 #include <cstdint>
 #include <iostream>
 #include <string>
+#include <vector>
 #endif
 
 /**
@@ -15,7 +15,7 @@
  * @return int64_t the minimum steps to make word1 equal to word2(i.e. the
  * distance of word1 and word2)
  */
-int64_t min_dist(std::string word1, std::string word2) {
+int64_t min_dist(const std::string word1, const std::string word2) {
   if (word1.size() == 0 && word2.size() == 0) {
     return 0;
   }
@@ -26,7 +26,7 @@ int64_t min_dist(std::string word1, std::string word2) {
     return word1.size();
   }
   int n = word1.size(), w = word2.size();
-  int dp[n + 1][w + 1];
+  std::vector<std::vector<int> > dp(n + 1, std::vector<int>(w + 1));
   for (int i = 0; i <= n; i++) {
     dp[i][0] = i;
   }
@@ -49,4 +49,4 @@ int64_t min_dist(std::string word1, std::string word2) {
   return dp[n][w];
 }
 
-#endif
+#endif

src/algorithms/string/find_and_replace.h

@@ -1,4 +1,3 @@
-#pragma once
 #ifndef ALGOPLUS_REGEX_PATTERNS_H
 #define ALGOPLUS_REGEX_PATTERNS_H
 
@@ -51,4 +50,4 @@ void find_and_replace(std::string &str, const std::string pattern,
   }
 }
 
-#endif // ALGOPLUS_REGEX_PATTERNS_H
+#endif // ALGOPLUS_REGEX_PATTERNS_H

src/algorithms/string/kmp.h

@@ -1,4 +1,3 @@
-#pragma once
 #ifndef KMP_H
 #define KMP_H
 
@@ -42,4 +41,4 @@ bool kmp(std::string pattern, std::string text) {
   return false;
 }
 
-#endif
+#endif

src/algorithms/string/rabin_karp.h

@@ -99,4 +99,4 @@ std::vector<size_t> rabin_karp(const std::string &text, const std::string &patte
     return result;
 }
 
-#endif
+#endif

src/classes/disjoint_set/disjoint_set.h

@@ -1,4 +1,3 @@
-#pragma once
 #ifndef DISJOINT_SET_H
 #define DISJOINT_SET_H
 
@@ -132,4 +131,4 @@ class dsu {
   int64_t get_min(int64_t i) { return min_el[find(i)]; }
 };
 
-#endif
+#endif

src/classes/graph/graph.h

@@ -1,4 +1,3 @@
-#pragma once
 #ifndef GRAPH_H
 #define GRAPH_H
 

src/classes/hash_table/hash_table.h

@@ -1,4 +1,3 @@
-#pragma once
 #ifndef HASH_TABLE_H
 #define HASH_TABLE_H
 

src/classes/heap/min_heap.h

@@ -1,4 +1,3 @@
-#pragma once
 #ifndef MIN_HEAP_H
 #define MIN_HEAP_H
 #ifdef __cplusplus
@@ -144,4 +143,4 @@ template <typename T> class min_heap {
   }
 };
 
-#endif
+#endif

src/classes/list/circular_linked_list.h

@@ -1,4 +1,3 @@
-#pragma once
 #ifndef CIRCULAR_LINKED_LIST_H
 #define CIRCULAR_LINKED_LIST_H
 
@@ -375,4 +374,4 @@ template <typename T> class circular_linked_list<T>::Iterator {
    */
   T operator*() { return curr_root->val; }
 };
-#endif
+#endif

src/classes/list/doubly_linked_list.h

@@ -1,4 +1,3 @@
-#pragma once
 #ifndef DOUBLY_LINKED_LIST_H
 #define DOUBLY_LINKED_LIST_H
 

src/classes/list/frequency_list.h

@@ -1,4 +1,3 @@
-#pragma once
 #ifndef FREQUENCY_LIST_H
 #define FREQUENCY_LIST_H
 

src/classes/list/linked_list.h

@@ -1,4 +1,3 @@
-#pragma once
 #ifndef LINKED_LIST_H
 #define LINKED_LIST_H
 

src/classes/list/skip_list.h

@@ -1,4 +1,3 @@
-#pragma once
 #ifndef SKIP_LIST_H
 #define SKIP_LIST_H
 

src/classes/queue/dequeue_list.h

@@ -1,4 +1,3 @@
-#pragma once
 #ifndef QUEUE_H
 #define QUEUE_H
 
@@ -241,4 +240,4 @@ template <typename T> class dequeue_list<T>::Iterator {
   T operator*() { return curr_root->val; }
 };
 
-#endif
+#endif