Add localauthority jwt prepare server command
#5418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Agustín Martínez Fayó <[email protected]>
amartinezfayo
requested review from
evan2645,
azdagron,
MarcosDY and
rturner3
as code owners
MarcosDY
approved these changes
Aug 23, 2024
Comment on lines
+64
to
+69
| if r.PreparedAuthority != nil { | ||
| env.Printf(" Authority ID: %s\n", r.PreparedAuthority.AuthorityId) | ||
| env.Printf(" Expires at: %s\n", time.Unix(r.PreparedAuthority.ExpiresAt, 0).UTC()) | ||
| } else { | ||
| return errors.New("internal error: expected to have prepared JWT authority information") | ||
| } |
There was a problem hiding this comment.
NIT:
Suggested change
| if r.PreparedAuthority != nil { | |
| env.Printf(" Authority ID: %s\n", r.PreparedAuthority.AuthorityId) | |
| env.Printf(" Expires at: %s\n", time.Unix(r.PreparedAuthority.ExpiresAt, 0).UTC()) | |
| } else { | |
| return errors.New("internal error: expected to have prepared JWT authority information") | |
| } | |
| if r.PreparedAuthority == nil { | |
| return errors.New("internal error: expected to have prepared JWT authority information") | |
| } | |
| env.Printf(" Authority ID: %s\n", r.PreparedAuthority.AuthorityId) | |
| env.Printf(" Expires at: %s\n", time.Unix(r.PreparedAuthority.ExpiresAt, 0).UTC()) |
There was a problem hiding this comment.
Sounds good. I'll go ahead and merge this, and then apply the suggestion in all the places where the same pattern applies, in a single separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
localauthority jwt prepareserver command.