Introduce support to localauthority CLI - x509 show #5400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amartinezfayo
requested review from
evan2645,
azdagron,
MarcosDY and
rturner3
as code owners
amartinezfayo
force-pushed
the
localauthority-cli-x509-show
branch
4 times, most recently
from
d009cf4 to
0d7cbd0
Compare
Signed-off-by: Agustín Martínez Fayó <[email protected]>
amartinezfayo
force-pushed
the
localauthority-cli-x509-show
branch
from
0d7cbd0 to
315321f
Compare
Signed-off-by: Agustín Martínez Fayó <[email protected]>
Signed-off-by: Agustín Martínez Fayó <[email protected]>
Signed-off-by: Agustín Martínez Fayó <[email protected]>
MarcosDY
reviewed
Aug 20, 2024
| @@ -126,6 +130,32 @@ func (cc *CLI) Run(ctx context.Context, args []string) int { | |||
| }, | |||
| } | |||
|
|
|||
| // TODO: Remove this when the forced_rotation feature flag is no longer | |||
There was a problem hiding this comment.
can you create an issue, and refer that issue here?
and add this as a function maybe, so it will be easier to detect what will be removed
Signed-off-by: Agustín Martínez Fayó <[email protected]>
MarcosDY
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce support to
localauthoritycommands in SPIRE Server.This is the first PR of a series of PRs adding
localauthoritycommands, allowing to interact with the LocalAuthority API to perform forced rotation and revocation of X.509 and JWT authorities in SPIRE.