New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix zero-blob tx check in Prague #1

Merged

spencer-tb merged 1 commit into spencer-tb:forks/prague from marioevz:fix-prague-zero-blob-check

Dec 5, 2024

marioevz commented Dec 4, 2024

Fix the zero-blob check in Prague.


          Fix zero-blob tx check in Prague

07f4774

Owner

spencer-tb commented Dec 5, 2024 •

edited

Loading

Quote from discord response:

Thanks for pushing this to finish line 🙌
The indirect fixtures is really cool!

Its worth mentioning that I directly added tests for the zero blob case twice in ethereum/execution-spec-tests#994, and indirectly in some of the multi block tests. So with the check re-added to EELS these cases now fail. My gut says that the check shouldn't exist for Prague but happy to adapt the tests 😄

Tentative based on what you think re. the 7742 tests PR: ethereum/execution-spec-tests#994

spencer-tb merged commit 51f5476 into spencer-tb:forks/prague

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet