-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Random.int added #773
Open
chase1k
wants to merge
6
commits into
main
Choose a base branch
from
759-feature-implement-randomint-function
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Random.int added #773
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
0e29258
Random.int added
5d575f5
Random.int test fix
965969b
Random.int make test more leanent
f692ce6
Typo fix and increasing test iterations
chase1k 2f307cf
Merge branch 'main' into 759-feature-implement-randomint-function
hulto 6e0f489
Merge branch 'main' into 759-feature-implement-randomint-function
jabbate19 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
use anyhow::Result; | ||
use rand::Rng; | ||
use rand_chacha::rand_core::SeedableRng; | ||
|
||
pub fn int(min: i32, max: i32) -> Result<i32> { | ||
if min >= max { | ||
return Err(anyhow::anyhow!("Invalid range")); | ||
} | ||
let mut rng = rand_chacha::ChaCha20Rng::from_entropy(); | ||
Ok(rng.gen_range(min..max)) | ||
} | ||
|
||
#[cfg(test)] | ||
mod tests { | ||
use super::*; | ||
|
||
const NUM_ITERATION: i32 = 50000; | ||
const MIN_VALUE: i32 = 0; | ||
const MAX_VALUE: i32 = 1000; | ||
|
||
#[test] | ||
fn test_random_int() -> anyhow::Result<()> { | ||
let random_number = int(MIN_VALUE, MAX_VALUE)?; | ||
assert!(random_number >= MIN_VALUE && random_number < MAX_VALUE); | ||
Ok(()) | ||
} | ||
|
||
#[test] | ||
fn test_random_int_uniform() -> anyhow::Result<()> { | ||
let mut counts = vec![0; MAX_VALUE as usize]; | ||
for _ in 0..NUM_ITERATION { | ||
let random_number = int(MIN_VALUE, MAX_VALUE)?; | ||
counts[random_number as usize] += 1; | ||
} | ||
|
||
let lower_bound = 0.90 * NUM_ITERATION as f64 / MAX_VALUE as f64; | ||
let upper_bound = 1.10 * NUM_ITERATION as f64 / MAX_VALUE as f64; | ||
|
||
for count in counts { | ||
assert!( | ||
count as f64 >= lower_bound && count as f64 <= upper_bound, | ||
"Count {} is not within the acceptable bounds of ({},{})", | ||
count, | ||
lower_bound, | ||
upper_bound | ||
); | ||
} | ||
Ok(()) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know math but seems okay.