-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(file imports): adds an experimental IFC parser #3525
Conversation
…e-results-path' into adam/ifc-dotnet
@iainsproat I think I fixed everything about docker....need confirmation of the corepack change |
📸 Preview service has generated an image. |
📸 Preview service has generated an image. |
📸 Preview service has generated an image. |
Two of the example files are failing on the step parser. I think it's because of whitespace/separator intolerance. |
@adamhathcock - If the two example files can be shown to pass the revised IFC parser, I'd be happy to approve for merging. We can then enable the feature flag on latest and have the wider team test it. We still need to investigate the file provided via speckle.community which was causing high memory usage. I don't consider it a blocker to merging though. It was reported as working on the original node js IFC parser if its memory limit is increased to 4Gi. What upper bound of memory is required for the .Net parser? Is there a memory leak or other memory-usage inefficiency we can resolve? |
📸 Preview service has generated an image. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appears to be about parity with the existing connector with respect to the example IFC models I have to hand.
Need @gjedlicska to approve and merge |
featureFlags.fileImportIFCDotNetEnabled
in Helm Chart orFF_FILEIMPORT_IFC_DOTNET_ENABLED
environment variable on the fileimport service in Docker Compose or local development environment.packages/fileimport-service/ifc-dotnet/ifcs