Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(file imports): adds an experimental IFC parser #3525

Merged
merged 51 commits into from
Nov 29, 2024
Merged

Conversation

adamhathcock
Copy link
Member

@adamhathcock adamhathcock commented Nov 20, 2024

  • experimental IFC parser can be toggled via feature flag, featureFlags.fileImportIFCDotNetEnabled in Helm Chart or FF_FILEIMPORT_IFC_DOTNET_ENABLED environment variable on the fileimport service in Docker Compose or local development environment.
  • Experimental IFC parser is built in .Net
  • File Import service Docker image is now based on Ubuntu and not Debian (distroless).
  • Example IFC files are now located in packages/fileimport-service/ifc-dotnet/ifcs

packages/fileimport-service/Dockerfile Outdated Show resolved Hide resolved
packages/fileimport-service/Dockerfile Outdated Show resolved Hide resolved
packages/fileimport-service/Dockerfile Outdated Show resolved Hide resolved
packages/fileimport-service/Dockerfile Outdated Show resolved Hide resolved
packages/fileimport-service/src/daemon.js Outdated Show resolved Hide resolved
packages/fileimport-service/Dockerfile Outdated Show resolved Hide resolved
@adamhathcock adamhathcock changed the title Adam/ifc dotnet Add the IFC dotnet converter Nov 21, 2024
@adamhathcock adamhathcock marked this pull request as ready for review November 21, 2024 13:05
iainsproat
iainsproat previously approved these changes Nov 21, 2024
@adamhathcock
Copy link
Member Author

@iainsproat I think I fixed everything about docker....need confirmation of the corepack change

Copy link
Contributor

📸 Preview service has generated an image.

Copy link
Contributor

📸 Preview service has generated an image.

Copy link
Contributor

📸 Preview service has generated an image.

@adamhathcock
Copy link
Member Author

Two of the example files are failing on the step parser. I think it's because of whitespace/separator intolerance.

@iainsproat
Copy link
Contributor

iainsproat commented Nov 28, 2024

@adamhathcock - do we have a better way of managing/importing wasm files, so that the provenance can be known and followed by a community member? #3525 (comment) edit: discussed and this was an existing file, so we will keep as is

If the two example files can be shown to pass the revised IFC parser, I'd be happy to approve for merging. We can then enable the feature flag on latest and have the wider team test it.

We still need to investigate the file provided via speckle.community which was causing high memory usage. I don't consider it a blocker to merging though. It was reported as working on the original node js IFC parser if its memory limit is increased to 4Gi. What upper bound of memory is required for the .Net parser? Is there a memory leak or other memory-usage inefficiency we can resolve?

Copy link
Contributor

📸 Preview service has generated an image.

Copy link
Contributor

@iainsproat iainsproat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears to be about parity with the existing connector with respect to the example IFC models I have to hand.

@adamhathcock
Copy link
Member Author

Need @gjedlicska to approve and merge

@iainsproat iainsproat changed the title Add the IFC dotnet converter feat(file imports): adds an experimental IFC parser Nov 28, 2024
@gjedlicska gjedlicska self-requested a review November 29, 2024 05:33
@gjedlicska gjedlicska merged commit 1ac972f into main Nov 29, 2024
43 of 44 checks passed
@gjedlicska gjedlicska deleted the adam/ifc-dotnet branch November 29, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants