Cast cache lifetime to integer by default #468
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may be specific to my production environment (Heroku) but I can into this issue when upgrading to Laravel 11, specifically with Carbon 3. I have
responsecache.cache_lifetime_in_seconds
set in my production environment Laravel pulls it into the config as a string.Carbon 3 blows up when passing a string to
addSeconds
here. Carbon 2 had no issues with accepting a string.Laravel 11 does include new config helpers to ensure you get a certain type (
Config::integer()
for example) but we can't use that here without dropping support for previous versions of Laravel.I've made this change in my app already but thought it was worthwhile to propose to include by default as more applications will adopt Carbon 3 alongside Laravel 11 and this makes the configuration value explicit.