feature(CacheItemSelector): add a condition in 'forget' method to be … #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able to forget by hashes(keys) also
freekmurze
requested changes
Oct 25, 2023
| @@ -35,6 +36,14 @@ public function forget(): void | |||
| { | |||
| collect($this->urls) | |||
| ->map(function ($uri) { | |||
| if ( | |||
| is_string($uri) && | |||
There was a problem hiding this comment.
I don't understand what this does. Could you refactor this to a method with a name that explains what it does? Don't use && but early returns in that method.
There was a problem hiding this comment.
thank you for your comment, I add 'isUriHashed' to explain that more clear
@freekmurze
|
Could you add tests for the new functionality? |
|
Dear contributor, because this pull request seems to be inactive for quite some time now, I've automatically closed it. If you feel this pull request deserves some attention from my human colleagues feel free to reopen it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a condition in 'forget' method to be able to forget by hashes(keys) also