Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: quash gumbo compiler warnings 202412 #3387

Merged
merged 2 commits into from
Dec 20, 2024
Merged

dev: quash gumbo compiler warnings 202412 #3387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f769a04
doc: fix typo in CHANGELOG
flavorjones Dec 16, 2024
8c6b0b4
style: address compiler warnings in the gumbo source
flavorjones Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Nokogiri follows [Semantic Versioning](https://semver.org/), please see the [REA

---

## 1.18.0.rc1 / 2024-12-16
## v1.18.0.rc1 / 2024-12-16

### Notable Changes

Expand Down
4 changes: 2 additions & 2 deletions gumbo-parser/src/ascii.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ const unsigned char _gumbo_ascii_table[0x80] = {
};

// Table generation code.
// clang -DGUMBO_GEN_TABLE=1 ascii.c && ./a.out && rm a.out
#if GUMBO_GEN_TABLE
// clang -DGUMBO_GEN_TABLE ascii.c && ./a.out && rm a.out
#ifdef GUMBO_GEN_TABLE
#include <stdio.h>

int main() {
Expand Down
4 changes: 2 additions & 2 deletions gumbo-parser/src/parser.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ static GumboNode* create_node(GumboNodeType type) {
return node;
}

static GumboNode* new_document_node() {
static GumboNode* new_document_node(void) {
GumboNode* document_node = create_node(GUMBO_NODE_DOCUMENT);
document_node->parse_flags = GUMBO_INSERTION_BY_PARSER;
gumbo_vector_init(1, &document_node->v.document.children);
Expand Down Expand Up @@ -1997,7 +1997,7 @@ static void adjust_svg_tag(GumboToken* token) {
assert(token->type == GUMBO_TOKEN_START_TAG);
if (token->v.start_tag.tag == GUMBO_TAG_FOREIGNOBJECT) {
assert(token->v.start_tag.name == NULL);
token->v.start_tag.name = "foreignObject";
token->v.start_tag.name = (char *)"foreignObject";
} else if (token->v.start_tag.tag == GUMBO_TAG_UNKNOWN) {
assert(token->v.start_tag.name);
const StringReplacement *replacement = gumbo_get_svg_tag_replacement(
Expand Down
Loading