Update metrics use of malfeasance package

[fasmat]

Motivation

Merge after #6566. This updates the way we handle metrics with malfeasance.

Description

Instead of passing along the metrics counter the domain specific handlers just return the labels that the malfeasance handler should use to report metrics.

Test Plan

existing tests were updated and extended

TODO

• Explain motivation or link existing issue(s)
• Test changes and document test plan
• Update documentation as needed
• Update changelog as needed

[codecov]

Codecov Report

Attention: Patch coverage is 64.15094% with 19 lines in your changes missing coverage. Please review.

Project coverage is 79.8%. Comparing base (bf8abb4) to head (de286ca).

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
activation/malfeasance.go	0.0%	6 Missing ⚠️
activation/malfeasance2.go	0.0%	6 Missing ⚠️
hare3/malfeasance.go	0.0%	2 Missing ⚠️
hare4/malfeasance.go	0.0%	2 Missing ⚠️
mesh/malfeasance.go	0.0%	2 Missing ⚠️
malfeasance/handler.go	97.0%	1 Missing ⚠️

Additional details and impacted files

@@                 Coverage Diff                 @@
##           malfeasance-info-v2   #6569   +/-   ##
===================================================
  Coverage                 79.8%   79.8%           
===================================================
  Files                      356     356           
  Lines                    47346   47366   +20     
===================================================
+ Hits                     37799   37838   +39     
+ Misses                    7400    7384   -16     
+ Partials                  2147    2144    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.