-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node-split: add smeshing identities endpoint to smesher service PoC #6452
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## node-split-poc #6452 +/- ##
================================================
- Coverage 78.0% 78.0% -0.1%
================================================
Files 337 339 +2
Lines 44937 45070 +133
================================================
+ Hits 35078 35173 +95
- Misses 7780 7824 +44
+ Partials 2079 2073 -6 ☔ View full report in Codecov by Sentry. |
activation/identity_states.go
Outdated
if len(s.identities[id].History) > 100 { | ||
s.identities[id].History = s.identities[id].History[1:] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to use something like a ring buffer to avoid reallocating the slice repeatedly (when the append below exceeds the capacity).
Co-authored-by: Bartosz Różański <[email protected]>
Description
Created smeshing identities endpoint based on #6266
Added states for post, poet and atxes.
TODO after PoC: state switch validation, better error handling
Example: