include node ID in ProposalBuildFailed event

spacemeshos · Dec 31, 2024 · 338ce11 · 338ce11
1 parent 850c706
commit 338ce11
Showing 1 changed file with 13 additions and 10 deletions.
diff --git a/miner/remote_proposals.go b/miner/remote_proposals.go
@@ -162,16 +162,19 @@ func (pb *RemoteProposalBuilder) build(
 	pb.signers.mu.Lock()
 	signers := maps.Values(pb.signers.signers)
 	pb.signers.mu.Unlock()
-	var err error
 	bcn, ok := beacons[epoch]
 	if !ok {
+		var err error
 		bcn, err = pb.beaconSvc.Beacon(ctx, epoch)
 		if err != nil {
-			pb.identityStates.Set(types.EmptyNodeID, &epoch, &smesherIdentity.ProposalBuildFailed{
-				ErrorMsg: fmt.Sprintf("beacon: %v", err),
-				Layer:    layer,
-			})
-			return fmt.Errorf("beacon: %w", err)
+			err = fmt.Errorf("getting beacon: %w", err)
+			for _, s := range signers {
+				pb.identityStates.Set(s.signer.NodeID(), nil, &smesherIdentity.ProposalBuildFailed{
+					ErrorMsg: err.Error(),
+					Layer:    layer,
+				})
+			}
+			return err
 		}
 		beacons[epoch] = bcn
 	}
@@ -197,7 +200,7 @@ func (pb *RemoteProposalBuilder) build(
 			)
 			eligibilities[nodeId] = proofs
 			pb.identityStates.SetEligibilities(nodeId, proofs)
-			pb.identityStates.Set(nodeId, &epoch, &smesherIdentity.Eligible{
+			pb.identityStates.Set(nodeId, nil, &smesherIdentity.Eligible{
 				Layers: proofs,
 			})
 		} else {
@@ -207,7 +210,7 @@ func (pb *RemoteProposalBuilder) build(
 		proposal, _, err := pb.proposalSvc.Proposal(ctx, layer, nodeId)
 		if err != nil {
 			pb.logger.Error("get partial proposal", zap.Error(err))
-			pb.identityStates.Set(nodeId, &epoch, &smesherIdentity.ProposalBuildFailed{
+			pb.identityStates.Set(nodeId, nil, &smesherIdentity.ProposalBuildFailed{
 				ErrorMsg: fmt.Sprintf("get partial proposal: %v", err),
 				Layer:    layer,
 			})
@@ -232,7 +235,7 @@ func (pb *RemoteProposalBuilder) build(
 		err = proposal.Initialize()
 		if err != nil {
 			pb.logger.Error("failed to initialize proposal", zap.Error(err))
-			pb.identityStates.Set(nodeId, &epoch, &smesherIdentity.ProposalBuildFailed{
+			pb.identityStates.Set(nodeId, nil, &smesherIdentity.ProposalBuildFailed{
 				ErrorMsg: fmt.Sprintf("failed to initialize proposal: %v", err),
 				Layer:    layer,
 			})
@@ -246,7 +249,7 @@ func (pb *RemoteProposalBuilder) build(
 				zap.Stringer("id", proposal.ID()),
 				zap.Error(err),
 			)
-			pb.identityStates.Set(nodeId, &epoch, &smesherIdentity.ProposalPublishFailed{
+			pb.identityStates.Set(nodeId, nil, &smesherIdentity.ProposalPublishFailed{
 				ErrorMsg: err.Error(),
 				Proposal: proposal.ID(),
 				Layer:    proposal.Layer,