Separate modules in submission artifact #239
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the submission archive is created by flattening all modules and source sets into a single source zip/jar. While this works well for single-module projects, it is not optimal for multiple modules.
This PR is part of a larger effort to make Jagr more module-aware. The first step is to split up modules in the submission archive similarly to the way modules are split up in subfolders during development. Modules are significantly more logically separate units than source sets (e.g. different classpath, dependencies etc...) so it makes sense to split them up into subfolders for the submission.
For now, source sets will continue to be flattened into one module output.