Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1896 #2445

Merged
merged 3 commits into from
Nov 28, 2023
Merged

fix #1896 #2445

merged 3 commits into from
Nov 28, 2023

Conversation

quentin
Copy link
Member

@quentin quentin commented Nov 28, 2023

Keep existing objects alive until the end of the MaterializeAggregationQueriesTransformer.

@quentin quentin requested a review from julienhenry November 28, 2023 10:53
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #2445 (1648eaa) into master (2914f7b) will increase coverage by 0.22%.
Report is 23 commits behind head on master.
The diff coverage is 77.61%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2445      +/-   ##
==========================================
+ Coverage   77.75%   77.98%   +0.22%     
==========================================
  Files         474      483       +9     
  Lines       31164    32012     +848     
==========================================
+ Hits        24232    24964     +732     
- Misses       6932     7048     +116     
Files Coverage Δ
src/FunctorOps.cpp 60.81% <ø> (ø)
src/RelationTag.h 53.03% <ø> (+0.79%) ⬆️
src/ast/Aggregator.cpp 95.65% <100.00%> (+0.19%) ⬆️
src/ast/Aggregator.h 100.00% <ø> (ø)
src/ast/Attribute.h 100.00% <100.00%> (ø)
src/ast/Component.h 100.00% <ø> (ø)
src/ast/IterationCounter.cpp 100.00% <100.00%> (ø)
src/ast/Lattice.h 100.00% <100.00%> (ø)
src/ast/Program.h 100.00% <ø> (ø)
src/ast/QualifiedName.h 94.11% <ø> (ø)
... and 80 more

... and 6 files with indirect coverage changes

Copy link
Member

@julienhenry julienhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix !

@quentin quentin merged commit cd6f2da into souffle-lang:master Nov 28, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants