Fixed CSV read failure involving blank lines in RFC4180 mode. #2434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem handling blank lines in a quoted CSV column when reading RFC4180 mode. Instead of continuing to read more lines, it dropped out assuming there was at least 1 character. Now, if the line we read contains 0 characters, it immediately goes back to read more lines. I did not notice this before, because the test did not use rfc4180 csv files for input or output.
This adds a test to make sure we can process quotes within a quoted column. Quotes in quotes need to be double-quoted.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2434 +/- ##
==========================================
+ Coverage 77.75% 77.94% +0.19%
==========================================
Files 474 479 +5
Lines 31164 31437 +273
==========================================
+ Hits 24232 24505 +273
Misses 6932 6932
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that blank lines in quoted columns lead to parse failures in RFC4180 mode. The fix is fairly straightforward and just requires checking for blank lines and just reading the next one.
I fixed some problems with load11 because were not testing what we wanted to test and did not use rfc4180 mode.
I also added a couple of additional tests.