Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

symbol concatenation with binary + #2431

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Conversation

quentin
Copy link
Member

@quentin quentin commented Oct 7, 2023

Introduce concatenation of symbol values with binary + operator.
Syntactic convenience since cat(...) already exists.

@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Merging #2431 (b891606) into master (2914f7b) will increase coverage by 0.15%.
Report is 16 commits behind head on master.
The diff coverage is 72.67%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2431      +/-   ##
==========================================
+ Coverage   77.75%   77.90%   +0.15%     
==========================================
  Files         474      479       +5     
  Lines       31164    31435     +271     
==========================================
+ Hits        24232    24491     +259     
- Misses       6932     6944      +12     
Files Coverage Δ
src/FunctorOps.cpp 60.81% <ø> (ø)
src/ast/IterationCounter.cpp 100.00% <100.00%> (ø)
src/ast/QualifiedName.h 94.11% <ø> (ø)
src/ast/Relation.h 100.00% <100.00%> (ø)
src/ast/Term.h 75.00% <100.00%> (-15.00%) ⬇️
src/ast/analysis/PrecedenceGraph.cpp 42.85% <100.00%> (+7.72%) ⬆️
src/ast/analysis/typesystem/Type.h 50.00% <ø> (ø)
...ast/analysis/typesystem/TypeConstrainsAnalysis.cpp 99.39% <100.00%> (+0.01%) ⬆️
...c/ast/analysis/typesystem/TypeConstrainsAnalysis.h 100.00% <ø> (ø)
src/ast/transform/ComponentInstantiation.cpp 92.33% <100.00%> (+0.16%) ⬆️
... and 36 more

... and 6 files with indirect coverage changes

@quentin quentin requested a review from julienhenry October 9, 2023 17:11
Copy link
Member

@julienhenry julienhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thanks !

@quentin quentin merged commit da9e3c2 into souffle-lang:master Oct 11, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants