Failed jars branch 20241014 #1146
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 14, 2024
stschott
requested changes
Dec 19, 2024
| "date": "2024-10-14" | ||
| } | ||
| ] | ||
| } |
There was a problem hiding this comment.
This file should be removed before merging.
| "download_url": "https://repo1.maven.org/maven2/de/sciss/audiofile_3.0.0-RC2/2.3.3/audiofile_3.0.0-RC2-2.3.3.jar", | ||
| "failedMethodSignature": "<de.sciss.audiofile.AudioFile$AsyncBasic: scala.concurrent.Future close()>" | ||
| } | ||
| ] |
There was a problem hiding this comment.
This file should also be removed before merging.
| JavaView javaView = supplyJavaView(jarDownloadUrl); | ||
| assertMethodConversion(javaView, methodSignature); | ||
| assertJar(javaView); | ||
| } |
There was a problem hiding this comment.
Please extract and isolate the cause of error within the jar and create a minimal test case. We do not want to download the jar each time we execute our test pipeline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.