Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: jonathan-r-thorpe <[email protected]>
  • Loading branch information
lo-simon and jonathan-r-thorpe authored Dec 15, 2023
1 parent d6614f1 commit e000094
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions Development/nmos-cpp-node/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ int main(int argc, char* argv[])
}
#endif

// only implement communication with Authorization server if IS-10 is required
// only implement communication with Authorization server if IS-10/BCP-003-02 is required
// cf. preprocessor conditions in nmos::make_node_api, nmos::make_connection_api, nmos::make_events_api, nmos::make_channelmapping_api, make_events_ws_validate_handler
nmos::experimental::authorization_state authorization_state;
if (nmos::experimental::fields::server_authorization(node_model.settings))
Expand Down Expand Up @@ -153,7 +153,7 @@ int main(int argc, char* argv[])
}
#endif

// only implement communication with Authorization server if IS-10 is required
// only implement communication with Authorization server if IS-10/BCP-003-02 is required
if (nmos::experimental::fields::client_authorization(node_model.settings))
{
std::map<nmos::host_port, web::http::experimental::listener::api_router> api_routers;
Expand Down
2 changes: 1 addition & 1 deletion Development/nmos/settings.h
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ namespace nmos

// authorization_flow [node]: used to specify the authorization flow for the registered scopes
// supported flow are authorization_code and client_credentials
// client_credentials SHOULD only be used for NO user interface node/registry, otherwise authorization_code MUST be used
// client_credentials SHOULD only be used when the node/registry has NO user interface, otherwise authorization_code MUST be used
const web::json::field_as_string_or authorization_flow{ U("authorization_flow"), U("authorization_code") };

// authorization_redirect_port [node]: redirect URL port for listening authorization code, used for client registration
Expand Down

0 comments on commit e000094

Please sign in to comment.