Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor activation Hessian computation using model builder #863

Merged
merged 11 commits into from
Nov 22, 2023

Conversation

ofirgo
Copy link
Collaborator

@ofirgo ofirgo commented Nov 21, 2023

Pull Request Description:

Removing the old dedicated mechanism that used inference on the model's graph to compute Hessian approximation with respect to intermediate activation tensors.
Instead, the new solution utilizes the model builder to build a model from the graph and then performs the Hessian approximation computation on the model.

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

@ofirgo ofirgo merged commit e921060 into sony:main Nov 22, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants