Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PyTorch 2.1 and add PyTorch tests for python 3.11 #854

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Support PyTorch 2.1 and add PyTorch tests for python 3.11 #854

merged 2 commits into from
Nov 8, 2023

Conversation

elad-c
Copy link
Collaborator

@elad-c elad-c commented Nov 8, 2023 •
edited
Loading

Pull Request Description:

This PR:

  • adds support for PyTorch 2.1
  • add support python 3.11 for PyTorch
  • removes python 3.8 tests for PyTorch

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

@elad-c elad-c requested a review from reuvenperetz November 8, 2023 08:06
reuvenperetz
reuvenperetz approved these changes Nov 8, 2023
View reviewed changes
.github/workflows/run_tests_python38_pytorch21.yml Outdated
@@ -0,0 +1,16 @@
name: Python 3.8, Pytorch 2.1
on:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we don't need to test this python version?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If not - update the readme as well

Remove python 3.8 tests
bf43eea 
Remove python 3.11 torch 1.13 test (doesn't support 3.11)
fix test for python 3.11
@elad-c elad-c merged commit f5aa9ae into main Nov 8, 2023
24 checks passed
@elad-c elad-c deleted the support_pytorch_21 branch November 8, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reuvenperetz reuvenperetz reuvenperetz approved these changes

Assignees
No one assigned
Labels
auto:tests pr: minor feature pytorch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elad-c @reuvenperetz @haihabi