-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add substitution for functional linear #1266
Merged
itai-berman
merged 6 commits into
sony:main
from
itai-berman:pytorch_subsitute_functionals
Nov 20, 2024
Merged
add substitution for functional linear #1266
itai-berman
merged 6 commits into
sony:main
from
itai-berman:pytorch_subsitute_functionals
Nov 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad-c
reviewed
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about torch.nn.functional.conv2d
and it's friends?
model_compression_toolkit/core/pytorch/graph_substitutions/substitutions/functional_linear.py
Outdated
Show resolved
Hide resolved
model_compression_toolkit/core/pytorch/graph_substitutions/substitutions/functional_linear.py
Outdated
Show resolved
Hide resolved
model_compression_toolkit/core/pytorch/graph_substitutions/substitutions/functional_linear.py
Outdated
Show resolved
Hide resolved
model_compression_toolkit/core/pytorch/graph_substitutions/substitutions/functional_linear.py
Outdated
Show resolved
Hide resolved
tests/pytorch_tests/model_tests/feature_models/linear_function_test.py
Outdated
Show resolved
Hide resolved
It seems that you already handled both Conv2d and ConvTranspose2d |
@itai-berman, please add Description to the PR |
Idan-BenAmi
reviewed
Nov 18, 2024
tests/pytorch_tests/model_tests/feature_models/linear_function_test.py
Outdated
Show resolved
Hide resolved
elad-c
approved these changes
Nov 18, 2024
tests/pytorch_tests/model_tests/feature_models/linear_function_test.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description:
Add substitution support from functional linear layer to Linear in Pytorch.
Checklist before requesting a review: