Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add substitution for functional linear #1266

Merged
merged 6 commits into from
Nov 20, 2024

Conversation

itai-berman
Copy link
Collaborator

@itai-berman itai-berman commented Nov 13, 2024

Pull Request Description:

Add substitution support from functional linear layer to Linear in Pytorch.

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

Copy link
Collaborator

@elad-c elad-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about torch.nn.functional.conv2d and it's friends?

@itai-berman
Copy link
Collaborator Author

It seems that you already handled both Conv2d and ConvTranspose2d FunctionalConvSubstitution and also FunctionalBatchNorm, FunctionalLayerNorm were handled

@haihabi
Copy link
Collaborator

haihabi commented Nov 18, 2024

@itai-berman, please add Description to the PR

@itai-berman itai-berman merged commit 4e76be8 into sony:main Nov 20, 2024
40 checks passed
@itai-berman itai-berman deleted the pytorch_subsitute_functionals branch November 20, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants