Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SLA + gradual activation quantization by default for PyTorch #1260

Merged
merged 5 commits into from
Nov 12, 2024

Conversation

irenaby
Copy link
Collaborator

@irenaby irenaby commented Nov 10, 2024

Pull Request Description:

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

@ofirgo ofirgo removed their request for review November 11, 2024 06:59
self.norm_scores = not self.per_sample
if self.log_norm is None:
self.log_norm = not self.per_sample
if self.scale_log_norm is None:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not setting scale_log_norm simply to false by default?

@irenaby irenaby merged commit 9ac9f54 into main Nov 12, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants