Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports FRR-VRRP configuration #813

Merged
merged 25 commits into from
Nov 21, 2024
Merged

Conversation

philo-micas
Copy link
Contributor

@philo-micas philo-micas commented Aug 22, 2023

@@ -410,7 +410,8 @@ namespace swss {
#define CFG_MCLAG_UNIQUE_IP_TABLE_NAME "MCLAG_UNIQUE_IP"

#define CFG_PORT_STORM_CONTROL_TABLE_NAME "PORT_STORM_CONTROL"

#define CFG_VRRP_TABLE_NAME "VRRP"
#define CFG_VRRP6_TABLE_NAME "VRRP6"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need similar table entry for APPL_DB too.

#define APP_VRRP_TABLE_NAME "VRRP_TABLE"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, has done.

@vvbrcm
Copy link
Contributor

vvbrcm commented Oct 30, 2024

Looks fine, please go ahead with merge.

@adyeung
Copy link

adyeung commented Oct 31, 2024

@qiluo-msft please help merge this, reviewed and approved by BRCM and Aviz

qiluo-msft
qiluo-msft previously approved these changes Nov 6, 2024
@philo-micas
Copy link
Contributor Author

@qiluo-msft We have resolved the code conflict, please help merge this again. Thanks.

@yuezhoujk yuezhoujk self-requested a review November 21, 2024 01:39
@yuezhoujk yuezhoujk merged commit ebd2afb into sonic-net:master Nov 21, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants