Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define table size per scaling test #644

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Define table size per scaling test #644

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff185b0
Reduce outbound routing to 4k and mapping to 8k by default
jimmyzhai Nov 8, 2024
73d3fa8
Update defines.h
jimmyzhai Nov 14, 2024
0740ac2
p4 src includes bmv2/*.h
jimmyzhai Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions dash-pipeline/bmv2/defines.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
#ifndef _DASH_DEFINES_H_
#define _DASH_DEFINES_H_

#ifdef TABLE_FULL_SCALE
Copy link
Collaborator

@r12f r12f Nov 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be better to use TABLE_BABY_HERO_SCALE

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TABLE_BABY_HERO_SCALE i believe it is in the range of 80K to 320K can we at least have the default limits increased to that
image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use TABLE_HERO_SCALE/TABLE_BABY_HERO_SCALE for hero/baby-hero respectively.

#define TABLE_CA_TO_PA_SIZE (8 * 1024 * 1024)
#define TABLE_ROUTING_SIZE (4 * 1024 * 1024)

#else /* default size */
#define TABLE_CA_TO_PA_SIZE (8 * 1024)
#define TABLE_ROUTING_SIZE (4 * 1024)

#endif


#endif /* _DASH_DEFINES_H_ */
3 changes: 2 additions & 1 deletion dash-pipeline/bmv2/stages/outbound_mapping.p4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
#define _DASH_STAGE_OUTBOUND_MAPPING_P4_

#include "../dash_routing_types.p4"
#include "../defines.h"

control outbound_mapping_stage(
inout headers_t hdr,
Expand All @@ -23,7 +24,7 @@ control outbound_mapping_stage(
set_private_link_mapping(hdr, meta);
@defaultonly drop(meta);
}
size = 8 * 1024 * 1024;
size = TABLE_CA_TO_PA_SIZE;
const default_action = drop(meta);

ATTACH_TABLE_COUNTER(ca_to_pa_counter)
Expand Down
3 changes: 2 additions & 1 deletion dash-pipeline/bmv2/stages/outbound_routing.p4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
#define _DASH_STAGE_OUTBOUND_ROUTING_P4_

#include "../dash_routing_types.p4"
#include "../defines.h"

control outbound_routing_stage(
inout headers_t hdr,
Expand Down Expand Up @@ -40,7 +41,7 @@ control outbound_routing_stage(
route_service_tunnel(hdr, meta);
drop(meta);
}
size = 4 * 1024 * 1024;
size = TABLE_ROUTING_SIZE;
const default_action = drop(meta);

ATTACH_TABLE_COUNTER(routing_counter)
Expand Down
Loading