Fix double deployment of unwanted plugin marker to Maven Central #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-botsco-2-0
bot
added
the
😧 commits missing verification
|
Thanks for the contribution. Unfortunately some of your commits don't meet our standards. All commits must be signed and have author information set. The commits to review are:
See Signed Commits. |
bhamail
approved these changes
Dec 18, 2024
| @@ -183,5 +183,16 @@ jreleaser { | |||
| } | |||
| } | |||
|
|
|||
| // Remove unwanted "scan" directory after publishing | |||
There was a problem hiding this comment.
If this is done "after publishing" would that mean the additional artifact would have been already uploaded to Central?
| @@ -15,5 +15,5 @@ | |||
| # | |||
|
|
|||
| group=org.sonatype.gradle.plugins | |||
| version=3.0.0-SNAPSHOT | |||
| version=3.1.0-SNAPSHOT | |||
There was a problem hiding this comment.
There is no change in the plugin code, if the intention is to test this releasing a new version then it's better just to increment the patch number:
Suggested change
| version=3.1.0-SNAPSHOT | |
| version=3.0.1-SNAPSHOT |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes extra deployment to Maven Central of unwanted plugin marker
Fixes issue #185