Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup the database configuration #5545

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Cleanup the database configuration #5545

merged 1 commit into from
Dec 11, 2023

Conversation

elia
Copy link
Member

@elia elia commented Dec 11, 2023

Summary

Refactor the ERB-pestered YAML in order to make it more readable, now using a classic default key and official rails adapter names.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia self-assigned this Dec 11, 2023
@elia elia requested a review from a team as a code owner December 11, 2023 13:57
@github-actions github-actions bot added changelog:solidus_core Changes to the solidus_core gem changelog:solidus_sample Changes to the solidus_sample gem labels Dec 11, 2023
@elia elia force-pushed the elia/database-config branch from d9a7553 to ea37ad3 Compare December 11, 2023 14:40
@github-actions github-actions bot added changelog:repository Changes to the repository not within any gem and removed changelog:solidus_sample Changes to the solidus_sample gem labels Dec 11, 2023
@elia elia merged commit 0e5b3e4 into main Dec 11, 2023
8 checks passed
@elia elia deleted the elia/database-config branch December 11, 2023 16:16
@forkata
Copy link
Contributor

forkata commented Dec 14, 2023

It looks like this change is causing failures when running specs on extensions against main https://app.circleci.com/pipelines/github/solidusio/solidus/5759/workflows/7a3da21a-d96a-41d6-bec5-cb4c1a144401 👀 I am not sure how solidus tests are still passing, but I guess we no longer generate a dummy app to run the gems tests.

@elia
Copy link
Member Author

elia commented Dec 15, 2023

@forkata I think I skipped a &default at this line https://github.com/solidusio/solidus/pull/5545/files#diff-06fe29b7aa56dcb8df94625d091064d3d8b3c6b24e03de7415646bd39762ca9dR20, thanks for the ping, fixing right away 👍

@elia
Copy link
Member Author

elia commented Dec 15, 2023

@forkata this is weird, the solidus_installer job only performs some steps and then stops in the run that's used for checks 🤔

@elia
Copy link
Member Author

elia commented Dec 15, 2023

This PR seems to be the culprit at which the installer specs stopped running before merges #5477, need to find a way to check the target branch instead of the source one.

@elia elia mentioned this pull request Dec 15, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adammathys adammathys adammathys approved these changes

Assignees

@elia elia

Labels
changelog:repository Changes to the repository not within any gem changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elia @forkata @adammathys