Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Admin] Add Option Types index component #5525

Merged
merged 2 commits into from
Nov 29, 2023
Merged

[Admin] Add Option Types index component #5525

merged 2 commits into from
Nov 29, 2023

Conversation

rainerdema
Copy link
Contributor

@rainerdema rainerdema commented Nov 29, 2023 •
edited
Loading

Summary

See #5522 first

Screenshot 2023-11-29 at 17 14 11

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@rainerdema rainerdema self-assigned this Nov 29, 2023
@rainerdema rainerdema force-pushed the rainerd/admin/add-option-types-index-page branch from 9252923 to b1f0db1 Compare November 29, 2023 16:29
@rainerdema rainerdema marked this pull request as ready for review November 29, 2023 16:41
@rainerdema rainerdema requested a review from a team as a code owner November 29, 2023 16:41
@rainerdema rainerdema requested a review from elia November 29, 2023 16:41
elia
elia reviewed Nov 29, 2023
View reviewed changes
Copy link
Member

@elia elia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I only left one comment asking for the use of existing page helpers

admin/app/components/solidus_admin/option_types/index/component.html.erb Outdated Show resolved Hide resolved
@rainerdema rainerdema force-pushed the rainerd/admin/add-option-types-index-page branch from b1f0db1 to 9958c0f Compare November 29, 2023 17:06
@rainerdema rainerdema force-pushed the rainerd/admin/add-option-types-index-page branch from 9958c0f to caf15c2 Compare November 29, 2023 17:41
@rainerdema rainerdema force-pushed the rainerd/admin/add-option-types-index-page branch from caf15c2 to d65b213 Compare November 29, 2023 17:51
@rainerdema rainerdema merged commit 68af924 into solidusio:main Nov 29, 2023
8 checks passed
@rainerdema rainerdema deleted the rainerd/admin/add-option-types-index-page branch November 29, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elia elia elia approved these changes

Assignees

@rainerdema rainerdema

Labels
changelog:solidus_admin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rainerdema @elia