[admin] Add scopes and controller helpers for ui/table
#5516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elia
force-pushed
the
elia+rainer/admin/index-table-features
branch
from
e4c294c to
7e1e5a2
Compare
This helps keeping the query URL short. Co-Authored-By: Rainer Dema <[email protected]>
Using not-allowed can be confusing when a button is disabled temporarily while submitting a form. Co-Authored-By: Rainer Dema <[email protected]>
This helps not interpreting a domain as a relative path. Also points the logo to the root of the admin. Co-Authored-By: Rainer Dema <[email protected]>
elia
force-pushed
the
elia+rainer/admin/index-table-features
branch
2 times, most recently
from
8209ff0 to
fda43bc
Compare
elia
changed the title
ui/table
The list of kwargs and the number of objects was very high, after this we can delegate some of the logic to supporting classes. Grouping by data and search kwargs might also help in future splitting or extraction of subcomponents. Co-Authored-By: Rainer Dema <[email protected]>
… mode Co-Authored-By: Rainer Dema <[email protected]>
…h mode Co-Authored-By: Rainer Dema <[email protected]>
elia
force-pushed
the
elia+rainer/admin/index-table-features
branch
from
fda43bc to
2e35075
Compare
This will be also the home for the upcoming scope support. Co-Authored-By: Rainer Dema <[email protected]>
Scopes are alternative pools of record on which further filtering can be performed. Co-Authored-By: Rainer Dema <[email protected]>
Co-Authored-By: Rainer Dema <[email protected]>
Co-Authored-By: Rainer Dema <[email protected]>
elia
force-pushed
the
elia+rainer/admin/index-table-features
branch
from
2e35075 to
73b1ded
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a big-ish refactoring of the
ui/tablecomponent, including:Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: