Solidus legacy color hierarchy #5446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_backend
The previous version of colors reflected exactly the new Solidus Admin, but its application on the legacy UI makes more difficult for merchants to individuate links and clickable elements.
elia
force-pushed
the
mfrecchiami/solidus-legacy-improvement
branch
from
5c64c3b to
24b97b7
Compare
elia
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When the Solidus Admin colors were extracted in a different file, we followed the color hierarchy of the New Solidus Admin Panel, in which the primary color is black. If this works in an admin panel where the UI has been updated, it creates issues on the Solidus Legacy version that loses its primary blue color.
In this PR, we have improved the color hierarchy for the Solidus Legacy version to facilitate user interactions.
e.g. understanding an element is clickable, having a hover effect on primary buttons, and keeping icons aligned on custom menu items.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: