Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SolidusAdmin products/stock component fixes #5443

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

elia
Copy link
Member

@elia elia commented Oct 19, 2023

Summary

  • add tests for .from_products
  • add .from_variant to support stock information for a single variant

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #5443 (cbcbb90) into main (e097f4a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #5443   +/-   ##
=======================================
  Coverage   88.89%   88.89%           
=======================================
  Files         612      612           
  Lines       14798    14800    +2     
=======================================
+ Hits        13154    13156    +2     
  Misses       1644     1644           
Files Coverage Δ
...mponents/solidus_admin/products/stock/component.rb 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elia elia marked this pull request as ready for review October 19, 2023 13:05
@elia elia requested a review from a team as a code owner October 19, 2023 13:05
@elia elia merged commit de6030b into main Oct 19, 2023
4 checks passed
@elia elia deleted the elia/admin/stock-component-fixes branch October 19, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants