Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract the table search field to a component #5428

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Conversation

elia
Copy link
Member

@elia elia commented Oct 10, 2023

Summary

image

Uses ui/forms/input under the hood, inheriting from it full styling.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia force-pushed the elia/admin/search-field branch from b6118eb to 0b2c035 Compare October 11, 2023 08:36
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #5428 (0b2c035) into main (7aec6d0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #5428   +/-   ##
=======================================
  Coverage   88.85%   88.85%           
=======================================
  Files         608      609    +1     
  Lines       14778    14784    +6     
=======================================
+ Hits        13131    13137    +6     
  Misses       1647     1647           
Files Coverage Δ
...mponents/solidus_admin/ui/forms/input/component.rb 100.00% <ø> (ø)
...s/solidus_admin/ui/forms/search_field/component.rb 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elia elia marked this pull request as ready for review October 11, 2023 09:25
@elia elia requested a review from a team as a code owner October 11, 2023 09:25
@elia elia requested review from rainerdema and removed request for a team October 11, 2023 09:26
@elia elia merged commit afc630e into main Oct 11, 2023
4 checks passed
@elia elia deleted the elia/admin/search-field branch October 11, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants