-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the link to customization guides #5404
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5404 +/- ##
==========================================
+ Coverage 88.86% 92.82% +3.96%
==========================================
Files 607 167 -440
Lines 14750 4127 -10623
==========================================
- Hits 13107 3831 -9276
+ Misses 1643 296 -1347 see 440 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
For information on how to customize your store, check out the [customization guides](https://guides.solidus.io/developers/customizations/overview.html). | ||
For information on how to customize your store, check out the [customization guides](https://guides.solidus.io/customization/customizing-your-storefront). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @pokonski, thanks for catching this!
I noticed there's also this link that unfortunately leads to a 404:
🚀 https://guides.solidus.io/developers/getting-started/first-time-installation
instead of
🚀 https://guides.solidus.io/getting-started/installing-solidus
If you could add this fix as well, that'd be awesome!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It probably makes sense to also add those to the guides redirects https://github.com/solidusio/edgeguides/blob/9bf18e4910f5124075dcd3041ce7368714f879ab/docusaurus.config.js#L178-L186
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @elia! Here's the PR link: solidusio/edgeguides#126
Hey @pokonski, I've incorporated the mentioned URL fix alongside your change. |
Summary
The current link results in 404, change it to a proper place in the docs
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: