Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the link to customization guides #5404

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Fix the link to customization guides #5404

merged 1 commit into from
Oct 6, 2023

Conversation

pokonski
Copy link
Contributor

@pokonski pokonski commented Oct 1, 2023

Summary

The current link results in 404, change it to a proper place in the docs

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@pokonski pokonski requested a review from a team as a code owner October 1, 2023 09:16
@github-actions github-actions bot added the changelog:solidus Changes to the solidus meta-gem label Oct 1, 2023
@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

Merging #5404 (e044473) into main (218cc43) will increase coverage by 3.96%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5404      +/-   ##
==========================================
+ Coverage   88.86%   92.82%   +3.96%     
==========================================
  Files         607      167     -440     
  Lines       14750     4127   -10623     
==========================================
- Hits        13107     3831    -9276     
+ Misses       1643      296    -1347     

see 440 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

kennyadsl
kennyadsl previously approved these changes Oct 2, 2023
For information on how to customize your store, check out the [customization guides](https://guides.solidus.io/developers/customizations/overview.html).
For information on how to customize your store, check out the [customization guides](https://guides.solidus.io/customization/customizing-your-storefront).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @pokonski, thanks for catching this!

I noticed there's also this link that unfortunately leads to a 404:

https://github.com/solidusio/solidus/blob/51f44e13c0ee967645f54a4a074ea262988c8a40/bin/sandbox#L104C4-L104C80

🚀 https://guides.solidus.io/developers/getting-started/first-time-installation

instead of

🚀 https://guides.solidus.io/getting-started/installing-solidus

If you could add this fix as well, that'd be awesome!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @elia! Here's the PR link: solidusio/edgeguides#126

@kennyadsl kennyadsl dismissed their stale review October 3, 2023 10:39

Didn't catch the 404

@github-actions github-actions bot added the changelog:repository Changes to the repository not within any gem label Oct 6, 2023
@rainerdema rainerdema requested a review from elia October 6, 2023 16:04
@rainerdema
Copy link
Contributor

Hey @pokonski, I've incorporated the mentioned URL fix alongside your change.
Thank you again for your contribution! 🙌

@rainerdema rainerdema merged commit 4b17a5d into solidusio:main Oct 6, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:repository Changes to the repository not within any gem changelog:solidus Changes to the solidus meta-gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants