Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[admin] Add a SolidusAdmin favicon #5387

Merged
merged 1 commit into from
Sep 19, 2023
Merged

[admin] Add a SolidusAdmin favicon #5387

merged 1 commit into from
Sep 19, 2023

Conversation

elia
Copy link
Member

@elia elia commented Sep 19, 2023

Summary

image

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia self-assigned this Sep 19, 2023
@elia elia requested a review from a team as a code owner September 19, 2023 15:21
@elia elia changed the base branch from main to nebulab/admin September 19, 2023 15:21
@elia elia requested a review from rainerdema September 19, 2023 15:21
@elia elia force-pushed the elia/admin/favicon branch from 4c4e58b to 64d692f Compare September 19, 2023 15:24
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #5387 (64d692f) into nebulab/admin (f4c0dc2) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           nebulab/admin    #5387   +/-   ##
==============================================
  Coverage          88.87%   88.87%           
==============================================
  Files                615      615           
  Lines              14861    14861           
==============================================
  Hits               13208    13208           
  Misses              1653     1653           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@rainerdema rainerdema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯
Should we backport this one to the alpha branch?

@elia
Copy link
Member Author

elia commented Sep 19, 2023

💯
Should we backport this one to the alpha branch?

I don't think it's necessary, it's cosmetic change 💅, not a blocking bug 👍

@elia elia merged commit 91d0668 into nebulab/admin Sep 19, 2023
4 checks passed
@elia elia deleted the elia/admin/favicon branch September 19, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants