-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[admin] Streamline form inputs #5385
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elia
force-pushed
the
elia/admin/form-components-cleanup
branch
4 times, most recently
from
September 18, 2023 15:45
fd651dc
to
7bce83d
Compare
Codecov Report
@@ Coverage Diff @@
## nebulab/admin #5385 +/- ##
=================================================
- Coverage 88.87% 88.78% -0.10%
=================================================
Files 615 606 -9
Lines 14861 14670 -191
=================================================
- Hits 13208 13025 -183
+ Misses 1653 1645 -8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
elia
force-pushed
the
elia/admin/form-components-cleanup
branch
from
September 19, 2023 11:18
7bce83d
to
92c1044
Compare
elia
force-pushed
the
elia/admin/form-components-cleanup
branch
from
September 19, 2023 11:33
92c1044
to
e83ede3
Compare
rainerdema
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
This will represent all input shaped elements like `input`, `textarea` and `select`.
elia
force-pushed
the
elia/admin/form-components-cleanup
branch
from
September 19, 2023 15:03
e83ede3
to
f6d9cf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Switches from using rails from builder helpers directly to raw components with higher level constructors that can rely on the form builder. This change brought in a considerate amount of simplification.
The
ui/forms/input
component is a candidate for splitting later on, most of the styles were shared between theinput
,select
, andtextarea
tags, but it will be under scrutiny for a split while we progress with building other pages.A bunch of the smaller UI details have been fixed (colors, spacing, etc.).
A basic version of the multi select is available but still not intended as the final solution, for which we'll need to find/build a substitute to
select2
.Finally preview playgrounds were setup separately for
input
,select, and
textarea`:Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: