Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[admin] Streamline form inputs #5385

Merged
merged 5 commits into from
Sep 19, 2023
Merged

Conversation

elia
Copy link
Member

@elia elia commented Sep 15, 2023

Summary

Switches from using rails from builder helpers directly to raw components with higher level constructors that can rely on the form builder. This change brought in a considerate amount of simplification.

image

The ui/forms/input component is a candidate for splitting later on, most of the styles were shared between the input, select, and textarea tags, but it will be under scrutiny for a split while we progress with building other pages.

A bunch of the smaller UI details have been fixed (colors, spacing, etc.).

A basic version of the multi select is available but still not intended as the final solution, for which we'll need to find/build a substitute to select2.

Finally preview playgrounds were setup separately for input, select, and textarea`:

image image image

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia self-assigned this Sep 15, 2023
@elia elia changed the base branch from main to nebulab/admin September 15, 2023 14:19
@elia elia force-pushed the elia/admin/form-components-cleanup branch 4 times, most recently from fd651dc to 7bce83d Compare September 18, 2023 15:45
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #5385 (f6d9cf2) into nebulab/admin (f4c0dc2) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

@@                Coverage Diff                @@
##           nebulab/admin    #5385      +/-   ##
=================================================
- Coverage          88.87%   88.78%   -0.10%     
=================================================
  Files                615      606       -9     
  Lines              14861    14670     -191     
=================================================
- Hits               13208    13025     -183     
+ Misses              1653     1645       -8     
Files Changed Coverage Δ
...mponents/solidus_admin/ui/forms/field/component.rb 100.00% <100.00%> (ø)
...mponents/solidus_admin/ui/forms/input/component.rb 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elia elia force-pushed the elia/admin/form-components-cleanup branch from 7bce83d to 92c1044 Compare September 19, 2023 11:18
@elia elia mentioned this pull request Sep 19, 2023
3 tasks
@elia elia force-pushed the elia/admin/form-components-cleanup branch from 92c1044 to e83ede3 Compare September 19, 2023 11:33
@elia elia changed the title [admin] form components cleanup [admin] Streamline form inputs Sep 19, 2023
@elia elia marked this pull request as ready for review September 19, 2023 12:08
@elia elia requested a review from a team as a code owner September 19, 2023 12:08
@elia elia requested a review from rainerdema September 19, 2023 12:08
@elia elia changed the base branch from nebulab/admin to main September 19, 2023 12:28
@elia elia changed the base branch from main to nebulab/admin September 19, 2023 12:28
Copy link
Contributor

@rainerdema rainerdema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@elia elia force-pushed the elia/admin/form-components-cleanup branch from e83ede3 to f6d9cf2 Compare September 19, 2023 15:03
@elia elia merged commit 7f55370 into nebulab/admin Sep 19, 2023
4 checks passed
@elia elia deleted the elia/admin/form-components-cleanup branch September 19, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants