[Admin] Add products#show

[elia]

Summary

There are still a few rough edges, but we can go from here. We're keeping track of lacking or broken things in an internal GH project (e.g. we'll build a component that will replace the original select2 behavior).

The Manage … links are pointing to sections in the original admin that still need to be ported to the new UI, e.g. adding a media uploading component (which is better handled in a separate PR).

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

• I have written a thorough PR description.
• I have kept my commits small and atomic.
• I have used clear, explanatory commit messages.

The following are not always needed:

• 📖 I have updated the README to account for my changes.
• 📑 I have documented new code with YARD.
• 🛣️ I have opened a PR to update the guides.
• ✅ I have added automated tests to cover my changes.
• 📸 I have attached screenshots to demo visual changes.

[tvdeyen]

Wondering if this should be product#edit instead, since we display forms? 🤔

[elia]

Wondering if this should be product#edit instead, since we display forms? 🤔

@tvdeyen yes, that's a good call, I did some research on how REST conceptualizes this stuff because I was torn between the this page being the only representation we have for the resource in the admin (there's no traditional show page) and this containing a form to modify the resource. I came out of that with the conclusion that /edit is an alternative representation of the same resource and that having no main representation (i.e. show page) that would become the main one.

With this in mind there are other considerations:

• do we want to stick to the legacy solidus_backend url?
• should we use get "/product/:id", as: :edit so only the url changes?

and so on and so forth.

I'm still conflicted so I'd like to hear from you, given the context above.
Renaming at this stage is cheap anyway ☺️

[codecov]

Codecov Report

Merging #5373 (6a907e0) into nebulab/admin (14c0127) will increase coverage by 0.13%.
The diff coverage is 92.42%.

@@                Coverage Diff                @@
##           nebulab/admin    #5373      +/-   ##
=================================================
+ Coverage          88.72%   88.86%   +0.13%     
=================================================
  Files                614      615       +1     
  Lines              14841    14860      +19     
=================================================
+ Hits               13168    13205      +37     
+ Misses              1673     1655      -18     

Files Changed	Coverage Δ
...omponents/solidus_admin/products/show/component.rb	76.92% <76.92%> (ø)
...p/controllers/solidus_admin/products_controller.rb	94.87% <84.61%> (-5.13%)	⬇️
...mponents/solidus_admin/products/index/component.rb	91.66% <100.00%> (ø)
...ponents/solidus_admin/ui/forms/select/component.rb	82.97% <100.00%> (-17.03%)	⬇️
...nts/solidus_admin/ui/forms/text_field/component.rb	100.00% <100.00%> (ø)
...app/components/solidus_admin/ui/panel/component.rb	100.00% <100.00%> (ø)
admin/lib/solidus_admin.rb	100.00% <100.00%> (ø)
admin/lib/solidus_admin/configuration.rb	100.00% <100.00%> (ø)
admin/lib/solidus_admin/engine.rb	100.00% <100.00%> (ø)
admin/lib/solidus_admin/importmap.rb	100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[rainerdema]

🌟 Amazing work! 🌟

[tvdeyen]

That are good arguments. What is the point of displaying a resource in an admin area anyway, right? And if we also consider authorization into account it makes even more sense to use the show route as it might be the case an unauthorized user only sees static values anyway. If we go with show routes, what about using it for all ongoing routes as well? So that we at least have a pattern here?

[elia]

That are good arguments. What is the point of displaying a resource in an admin area anyway, right? And if we also consider authorization into account it makes even more sense to use the show route as it might be the case an unauthorized user only sees static values anyway. If we go with show routes, what about using it for all ongoing routes as well? So that we at least have a pattern here?

For sure, we'll head that way for all the routes of the new dashboard and ensure that you can go back and forth during the transition time 👍