Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated quarkus annotation #560

Merged
merged 3 commits into from
Aug 9, 2024
Merged

Update deprecated quarkus annotation #560

merged 3 commits into from
Aug 9, 2024

Conversation

edwardsph
Copy link
Collaborator

With the Quarkus 3.13 update, the QuarkusTestResource annotation has been deprecated in favour of WithTestResource. This updates our use of the annotation.

@edwardsph edwardsph enabled auto-merge (squash) August 9, 2024 09:14
@edwardsph edwardsph requested a review from acoburn August 9, 2024 13:15
Copy link
Collaborator

@acoburn acoburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'd shorten the annotation definitions

Remove unnecessary parameter in annotations

Co-authored-by: Aaron Coburn <[email protected]>
Copy link

sonarqubecloud bot commented Aug 9, 2024

@edwardsph edwardsph merged commit 4033328 into main Aug 9, 2024
3 checks passed
@edwardsph edwardsph deleted the quarkus branch August 9, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants