Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace CKR_GENERAL_ERROR with CKR_ENCRYPTED_DATA_INVALID or CKR_ENCRYPTED_DATA_LEN_RANGE upon decryption failure #690

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Replace CKR_GENERAL_ERROR with CKR_ENCRYPTED_DATA_INVALID or CKR_ENCRYPTED_DATA_LEN_RANGE upon decryption failure #690

wants to merge 2 commits into from

Conversation

hansonchar
Copy link

See #689

@hansonchar
Copy link
Author

I see the CI/CD workflow involved downloading of some files but the downloading failed. Any idea how to unblock?

@jschlyter jschlyter requested a review from bjosv December 14, 2024 16:14
@jschlyter jschlyter marked this pull request as draft December 14, 2024 16:15
@jschlyter
Copy link
Contributor

Please rebase so Github actions are included.

@hansonchar
Copy link
Author

Rebased

bjosv
bjosv approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@bjosv bjosv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks correct to me.

@jschlyter jschlyter marked this pull request as ready for review December 17, 2024 10:58
@jschlyter jschlyter requested a review from a team as a code owner December 17, 2024 10:58
@jschlyter jschlyter linked an issue Dec 18, 2024 that may be closed by this pull request
Failure in decrypting invalid ciphertext should not return CKR_GENERAL_ERROR #689
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjosv bjosv bjosv approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failure in decrypting invalid ciphertext should not return CKR_GENERAL_ERROR
3 participants
@hansonchar @jschlyter @bjosv