Allow using new C++ standards when building #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
jmigual
reviewed
May 29, 2024
|
Just noticed that I could fix the typo myself 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
We are packaging Socket IO Client in Conan (PR conan-io/conan-center-index#24112) and we use multiple C++ standards in our CI, including C++11 and newer versions.
We found that Socket IO is using C++11 only, via set_property() in CMakeLists.txt. So, this PR replaces that function by target_compile_features, so we can pass
CMAKE_CXX_STANDARDand override C++11 to something newer like C++14/17/20/23 (set_property() does not allow override).Plus, I updated threads requirement in the project: