Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[READY] - gha: removing set-output due to deprecation #629

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

sarcasticadmin
Copy link
Member

@sarcasticadmin sarcasticadmin commented Oct 7, 2023

Description of PR

Fixes: #610

Relates to: #611 (python3 removal)

More deprecations from gha, specifically set-output: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Previous Behavior

  • trigger workflow uses set-output
  • Checking for python3, and zabbix in serverspec tests

New Behavior

  • trigger workflow uses $GITHUB_OUTPUT
  • removed serverspec tests that were checking for binaries/services that are no longer present

Tests

{"ref":"rh/1696716150gha","variables":{"OPENWRT_INTEG":"YES","WORMHOLE_CODE":"tony-1-hello"},"id":"17362342"}

@github-actions
Copy link

github-actions bot commented Oct 7, 2023

[RUNNING] - Successfully triggered gitlab flash pipeline:

Copy link

github-actions bot commented Nov 8, 2023

[RUNNING] - Successfully triggered gitlab flash pipeline:

Copy link

github-actions bot commented Nov 8, 2023

[RUNNING] - Successfully triggered gitlab flash pipeline:

Copy link

github-actions bot commented Nov 8, 2023

[RUNNING] - Successfully triggered gitlab flash pipeline:

Copy link

github-actions bot commented Nov 8, 2023

[RUNNING] - Successfully triggered gitlab flash pipeline:

@sarcasticadmin sarcasticadmin changed the title [WIP] - gha: removing set-output due to deprecation [READY] - gha: removing set-output due to deprecation Nov 8, 2023
Copy link
Collaborator

@owendelong owendelong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great... I especially like removing python from default bins. ;-)

@owendelong owendelong self-requested a review November 8, 2023 06:15
@owendelong owendelong merged commit 1e7d542 into master Nov 8, 2023
3 checks passed
@owendelong owendelong deleted the rh/1696716150gha branch November 8, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GHA deprecation warnings for existing actions
2 participants