[READY] - golden-tests: migrate to nix check #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarcasticadmin
force-pushed
the
rh/1696709124gomplate
branch
2 times, most recently
from
6ad4d8c to
62ed00b
Compare
sarcasticadmin
force-pushed
the
rh/1696709124gomplate
branch
from
62ed00b to
5526839
Compare
sarcasticadmin
changed the title
owendelong
approved these changes
Oct 18, 2023
|
thanks for the merge @owendelong ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Relates to: #627
Moving the openwrt golden test to nix checks.
Sidenote: Given how the work existing workflow via nix.check has grown maybe its best we rename the workflow.yml? I spun out an issue to look into this vs doing it in this PR: #630
Previous Behavior
New Behavior
Tests