Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WAIT] - Adding nix ci to github actions #512

Closed
wants to merge 3 commits into from
Closed

Conversation

sarcasticadmin
Copy link
Member

@sarcasticadmin sarcasticadmin commented Dec 24, 2022

Description of PR

Depends on: #509
Fixes: #510

Adding initial nix ci for nixpkgs-fmt

Previous Behavior

  • No formatting present for .nix files

New Behavior

  • Formatting and checks for *.nix

Tests

  • Running the checks locally while inside a devShell
$ nix develop --command treefmt --fail-on-change --no-cache && git --no-pager diff
[INFO]: #nix: 8 files processed in 12.79ms

traversed 290 files
matched 8 files to formatters
left with 8 files after cache
of whom 0 files were re-formatted
all of this in 23ms

@sarcasticadmin sarcasticadmin changed the title [REVIEW] - Adding nix ci to github actions [WAIT] - Adding nix ci to github actions Dec 24, 2022
@sarcasticadmin sarcasticadmin force-pushed the rh/issue-510 branch 2 times, most recently from 640d136 to ff9236e Compare December 27, 2022 05:49
@sarcasticadmin sarcasticadmin changed the title [WAIT] - Adding nix ci to github actions [READY] - Adding nix ci to github actions Dec 27, 2022
@@ -0,0 +1,3 @@
[formatter.nix]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: Leveraging https://github.com/numtide/treefmt with the hopes of being able to add additional stanzas for https://github.com/numtide/treefmt/wiki#shell) and python via the black formatter (https://github.com/numtide/treefmt/wiki#python)

@sarcasticadmin
Copy link
Member Author

@owendelong this ones been rebased and ready to go!

@sarcasticadmin
Copy link
Member Author

sarcasticadmin commented Jan 2, 2023

Nevermind, moving this back to [WAIT]. The CI takes way to long in its current state: https://github.com/socallinuxexpo/scale-network/actions/runs/3820953513/jobs/6499648333 Going to see if theres a way to speed it up before we merge

@sarcasticadmin sarcasticadmin changed the title [READY] - Adding nix ci to github actions [WAIT] - Adding nix ci to github actions Jan 2, 2023
@sarcasticadmin
Copy link
Member Author

closing in favor of #625

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run simple nix fmt and flake ci checks
1 participant