Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[READY] - nix: refactor and update #625

Merged
merged 3 commits into from
Oct 12, 2023

Conversation

Kranzes
Copy link
Contributor

@Kranzes Kranzes commented Sep 30, 2023

Description of PR

Relates to: #627

  • Moving perl tests to be trigger via nix instead of from inside docker
  • Refactoring nix to leverage flake.parts to utilize the module system for all aspects in the flake

Update

Going to probably unify more of our gha tests into a single gha workflow.yml in a follow up.

Previous Behavior

  • Testing perl ci via docker
  • Not using flake.parts within the flake

New Behavior

  • perl runs via nix checks in ci
  • flake.parts and refactoring of the nix code for the flake

Tests

  • CI tests pass

Can run all of our tests in one go via:

nix flake check

@sarcasticadmin
Copy link
Member

Thanks for raising this! Ill take this for a spin shortly!

@sarcasticadmin sarcasticadmin marked this pull request as ready for review October 7, 2023 11:07
@sarcasticadmin sarcasticadmin changed the title nix: refactor and update [READY] - nix: refactor and update Oct 7, 2023
Copy link
Member

@sarcasticadmin sarcasticadmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kranzes thanks a lot for all of the help getting this refactored into flake.parts, it looks awesome and seems really helpful for us going forward! :shipit:

Ill wait for others to comment/review since I added a couple of fixups to the branch for the CI tests.

@@ -16,4 +16,5 @@ jobs:
- uses: actions/checkout@v3
- uses: DeterminateSystems/nix-installer-action@main
- uses: DeterminateSystems/magic-nix-cache-action@main
- run: nix build -L .#checks.pytest-facts
- run: nix build -L .#checks.x86_64-linux.pytest-facts
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you run nix flake check it will evaluate all the code in the repo, even nixos configurations and build all derivations under the checks output.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, but I think itll have an issue running all tests due to the need for qemu in github actions

Copy link
Collaborator

@owendelong owendelong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any issues, but honestly, I don't really know what I'm looking at, so my comments are of minimal value here.

@sarcasticadmin
Copy link
Member

@owendelong I'm happy to give you a primer on more of this during the work party, thanks for looking at it regardless

@Kranzes
Copy link
Contributor Author

Kranzes commented Oct 11, 2023

Once we get this merged I can work with @sarcasticadmin on removing dead code and repeating ourselves a bit less by using some functions magic.

Copy link
Member

@kylerisse kylerisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Kranzes . Appreciate the help.

@kylerisse kylerisse merged commit 4699e5e into socallinuxexpo:master Oct 12, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants