-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[READY] - nix: refactor and update #625
Conversation
Thanks for raising this! Ill take this for a spin shortly! |
c67eec0
to
5089efd
Compare
290435d
to
44f416f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kranzes thanks a lot for all of the help getting this refactored into flake.parts, it looks awesome and seems really helpful for us going forward!
Ill wait for others to comment/review since I added a couple of fixups to the branch for the CI tests.
@@ -16,4 +16,5 @@ jobs: | |||
- uses: actions/checkout@v3 | |||
- uses: DeterminateSystems/nix-installer-action@main | |||
- uses: DeterminateSystems/magic-nix-cache-action@main | |||
- run: nix build -L .#checks.pytest-facts | |||
- run: nix build -L .#checks.x86_64-linux.pytest-facts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you run nix flake check
it will evaluate all the code in the repo, even nixos configurations and build all derivations under the checks
output.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed, but I think itll have an issue running all tests due to the need for qemu in github actions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any issues, but honestly, I don't really know what I'm looking at, so my comments are of minimal value here.
@owendelong I'm happy to give you a primer on more of this during the work party, thanks for looking at it regardless |
Once we get this merged I can work with @sarcasticadmin on removing dead code and repeating ourselves a bit less by using some functions magic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Kranzes . Appreciate the help.
Description of PR
Relates to: #627
perl
tests to be trigger via nix instead of from inside dockerUpdate
Going to probably unify more of our gha tests into a single gha workflow.yml in a follow up.
Previous Behavior
perl
ci via dockerNew Behavior
perl
runs via nix checks in ciTests
Can run all of our tests in one go via: