BUGFIX for #193: Populate options.host when account is inferred #202 (try #2) #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Check if command being executed is GET * Add GET functionality to file transfer agent * Add GET functionality to remote storage util * Add download function to S3 client * Fix decryption when downloading more than one file * Add Azure client for GET * Add GCS client for GET * Add local client for GET * Add testing for GET command * Add temp debug msg * Remove temp debug msg * Modify GET query on Windows OS
* Update/add request-related dependencies * Update/add request-related dependencies
…1.6.6 (snowflakedb#245) (snowflakedb#246) @noreview - This is an automated process. No review is required. Co-authored-by: Jenkins User <snowflake-provisioner>
Added test case to reproduce failure. Set hostname from accessURL when account is inferred.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I corrupted my first attempt at this pull request so I'm trying again.
This is my first PR so please be gentle!! My company uses Snowflake internally and I'm excited to contribute!
I took a look at #193 and noticed the root cause seems to be that options.host is typically inferred from options.accounts, and so when options.accounts is inferred from the options.accessUrl it will remain unset and result in a crash starting with 1.6.2. The fix is to also set options.host when inferring the options.account.
I've also added a test case.
~ Matt