Add with grant option flag to streamlit share #1967
+45
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
I've added a
--with-grant-option
flag tosnow streamlit share
to grant the ability to share the app to the role that the app is being shared to.I've run the tests locally and have run into two failures, which I believe may not be impactful. The help message failure seems to be just due to whitespace due to the addition of the longer-named flag. I am not familiar with the other failure however.
I am also unfortunately unable to run this command locally, due to some networking restrictions at my company. I've confirmed the addition of the flag via the
--help
menu. This is a fairly small change, so I don't foresee many issues, but if anyone is able to verify for me, that would be great.Resolves #1961