Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add with grant option flag to streamlit share #1967

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

thomas-lochner
Copy link

@thomas-lochner thomas-lochner commented Dec 27, 2024

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

I've added a --with-grant-option flag to snow streamlit share to grant the ability to share the app to the role that the app is being shared to.

I've run the tests locally and have run into two failures, which I believe may not be impactful. The help message failure seems to be just due to whitespace due to the addition of the longer-named flag. I am not familiar with the other failure however.
image

I am also unfortunately unable to run this command locally, due to some networking restrictions at my company. I've confirmed the addition of the flag via the --help menu. This is a fairly small change, so I don't foresee many issues, but if anyone is able to verify for me, that would be great.

Resolves #1961

@thomas-lochner thomas-lochner requested a review from a team as a code owner December 27, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SNOW-1866641: Allow giving targeted role ability to view AND share with snow streamlit share
1 participant