Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix connection Config Config heading #1284

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

afeld
Copy link

@afeld afeld commented Dec 30, 2024

The heading wasn't being rendered: https://pkg.go.dev/github.com/snowflakedb/gosnowflake

Description

Added a missing newline.

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

@afeld afeld requested a review from a team as a code owner December 30, 2024 09:15
Copy link

github-actions bot commented Dec 30, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@afeld
Copy link
Author

afeld commented Dec 30, 2024

I have read the CLA Document and I hereby sign the CLA

@@ -167,12 +168,12 @@ you are looking to connect. Since the driver name is not needed, you can optiona
on startup. To do this, set `GOSNOWFLAKE_SKIP_REGISTERATION` in your environment. This is useful you wish to
register multiple verions of the driver.

Note: GOSNOWFLAKE_SKIP_REGISTERATION should not be used if sql.Open() is used as the method
Note: `GOSNOWFLAKE_SKIP_REGISTERATION` should not be used if sql.Open() is used as the method
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note: REGISTERATION is spelled wrong 😉 It seems to be that way in the code as well, so didn't want to change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant