Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show PIN pad as default; Unlock screen with RFID (only for Cards & Colors themes) #2807

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Fluxxo
Copy link

@Fluxxo Fluxxo commented Dec 10, 2023

I've implemented some UX features I found handy in day2day handling of the OpenWB:

  1. The themes "cards" and "colors" showed a modal dialog that a pin is required for unlocking. One would always need to hit the rather tiny lock icon to use a locked display to show the number pad. The changed behaviour is that the PIN pad displays by default whenever an action is used requiring an unlocked screen.

  2. Additionally, the "success" feedback (flashing background in green) was reduced from 1000ms to 250ms, avoiding an unnecessary delay after successful input

  3. The PIN pad will submit automatically after the fourth digit is entered, avoiding the need to tap the "enter" button, reducing necessary user interactions for quicker usage.

  4. Users can now unlock the screen by presenting their RFID token. The screen locks automatically after the configured time. To achieve this:

  • Added a property to the RFID settings page to allow screen unlocking
  • Added a new default property to openwb.conf named "unlockscreenrfid", allowing to store the respective property
  • If the property is set, the values.php file will check for respective RFID token configurations in the respective settings of assigned cars (if RFID mode = 1), e.g., rfidlp1c1, rfidlp1c2, rfidlp1c3. If RFID mode = 2, the values of the config rfidlist will be used. values.php will check if the GET parameter rfidlist ist set and assigned a value, otherwise it will redict to itself append ?rfidlist=xxx,yyy,zzz
  • The respective index.html will parse the HTTP request parameters and store them in a global variable
  • The RFID reader acts like a keyboard. The page captures keyboard inputs (the RFID reader actually works like a keyboard) and once an RFID token is checked successfully against the configured tag ids, the screen will unlock.
  • All functionalities remain untouched, so activating the charging point, setting charging mode, etc. Just additionally the screen unlocks and locks later on again.
  1. Also added a debug statement with values for Hausverbrauch calculation. Not necessarily related to this PR but still helpful I find.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant