Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardise link/counter names #1025

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

eugeneia
Copy link
Member

@eugeneia eugeneia commented Sep 23, 2016

As discussed in #871 this PR the shorthands “rx” and “tx” are removed from link and counter (SHM) names and replaced with “input” and “output”. This change affects many modules and the changes to each module should be reviewed by their authors/maintainers.

The most notable change that the translation is reversed for link counters, e.g. rx is now output and tx is input, e.g.:

  • input = packets enqueued on the link (was: tx = packets transmitted onto the link)
  • output = packets dequeued from the link (was: rx = packets received off the link)

Depends on: #1019

Notable change: link counters are reversed:
 - input == enqueued onto the link
 - output == dequeued from the link
@eugeneia eugeneia changed the title [wip] standardise link/counter names standardise link/counter names Sep 26, 2016
# Conflicts:
#	src/apps/intel/intel_app.lua
#	src/apps/tap/tap.lua
#	src/apps/test/match.lua
#	src/apps/vlan/vlan.lua
@lukego
Copy link
Member

lukego commented Oct 12, 2016

Great initiative! Have only given it a quick run-through but no problems jump out at me.

@kbara kbara self-assigned this Oct 12, 2016
kbara pushed a commit to kbara/snabb that referenced this pull request Oct 12, 2016
@eugeneia eugeneia mentioned this pull request Oct 18, 2016
2 tasks
@eugeneia
Copy link
Member Author

See further discussion in #1030

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants