Fixed initial value type inference

smikhalevski · Apr 30, 2024 · 0de0aab · 0de0aab
1 parent 9a0e34e
commit 0de0aab
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 4 deletions.
diff --git a/src/main/ExecutorManager.ts b/src/main/ExecutorManager.ts
@@ -1,6 +1,6 @@
 import { AbortablePromise, PubSub } from 'parallel-universe';
 import { ExecutorImpl } from './ExecutorImpl';
-import type { Executor, ExecutorEvent, ExecutorPlugin, ExecutorState, ExecutorTask } from './types';
+import type { Executor, ExecutorEvent, ExecutorPlugin, ExecutorState, ExecutorTask, NoInfer } from './types';
 
 /**
  * Creates executors and manages their lifecycle.
@@ -67,7 +67,7 @@ export class ExecutorManager implements Iterable<Executor> {
   getOrCreate<Value = any>(
     key: string,
     initialValue?: ExecutorTask<Value> | PromiseLike<Value> | Value,
-    plugins?: Array<ExecutorPlugin<Value> | undefined | null>
+    plugins?: Array<ExecutorPlugin<NoInfer<Value>> | undefined | null>
   ): Executor<Value>;
 
   getOrCreate(key: string, initialValue?: unknown, plugins?: Array<ExecutorPlugin | undefined | null>): Executor {

diff --git a/src/main/types.ts b/src/main/types.ts
@@ -315,3 +315,10 @@ export interface Executor<Value = any> extends ExecutorState<Value> {
    */
   toJSON(): ExecutorState<Value>;
 }
+
+/**
+ * Poor Man's NoInfer polyfill.
+ */
+// https://www.typescriptlang.org/docs/handbook/release-notes/typescript-2-8.html#type-inference-in-conditional-types
+// https://devblogs.microsoft.com/typescript/announcing-typescript-5-4-beta/#the-noinfer-utility-type
+export type NoInfer<T> = [T][T extends any ? 0 : never];
diff --git a/src/main/useExecutor.ts b/src/main/useExecutor.ts
@@ -1,5 +1,5 @@
 import { useDebugValue, useEffect, useState } from 'react';
-import type { Executor, ExecutorPlugin, ExecutorTask } from './types';
+import type { Executor, ExecutorPlugin, ExecutorTask, NoInfer } from './types';
 import { useExecutorManager } from './useExecutorManager';
 
 /**
@@ -39,7 +39,7 @@ export function useExecutor<Value = any>(
 export function useExecutor<Value = any>(
   key: string,
   initialValue?: ExecutorTask<Value> | PromiseLike<Value> | Value,
-  plugins?: Array<ExecutorPlugin<Value> | undefined | null>
+  plugins?: Array<ExecutorPlugin<NoInfer<Value>> | undefined | null>
 ): Executor<Value>;
 
 /**