io.skymap.read_skymap(): no_hdu parameter #159
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We avoided memory issues in SkyPortal (in production) by dropping the
hdu
variable (and others) created bygwemopt
when reading a skymap before calling the scheduler, however just creating the variable can require some amount of memory and create issues, so this PR simply adds an argument to avoid creating said variable altogether. The default is to still create it (to not impact any existing workflows), but one can explicitly avoid it by setting that new optional flag to True.I also rearranged a few things in that function + fixed one line that looked suspicious to me (where the
skymap_schedule
variable was set using theskymap_raster
and not theskymap_raster_schedule
).