Add support for nonkube listener commands #1778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lynnemorrison
force-pushed
the
v2_nonkube_listener
branch
from
e203e33 to
a6eca55
Compare
|
The issue #1777 needs to be addressed before merging this PR |
lynnemorrison
force-pushed
the
v2_nonkube_listener
branch
from
a6eca55 to
f045707
Compare
fgiorgetti
reviewed
Nov 18, 2024
lynnemorrison
force-pushed
the
v2_nonkube_listener
branch
from
ac24e9c to
99cbfc6
Compare
fgiorgetti
reviewed
Dec 3, 2024
lynnemorrison
force-pushed
the
v2_nonkube_listener
branch
2 times, most recently
from
2307815 to
aee34c4
Compare
nluaces
reviewed
Dec 10, 2024
nluaces
reviewed
Dec 10, 2024
lynnemorrison
force-pushed
the
v2_nonkube_listener
branch
from
aee34c4 to
cc50135
Compare
nluaces
approved these changes
Dec 12, 2024
|
this pr needs to rebase from v2, that way the build won't fail. |
Also appied comments to nonkube connector commands.
Stderr for warning messages
lynnemorrison
force-pushed
the
v2_nonkube_listener
branch
from
1811ad6 to
436cf95
Compare
lynnemorrison
force-pushed
the
v2_nonkube_listener
branch
from
436cf95 to
6e35887
Compare
nluaces
approved these changes
Dec 12, 2024
fgiorgetti
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add nonkube listener CLI and unit tests.